Chaos mode in Realm of Legends - generate valid Commander decks#10224
Open
MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
Open
Chaos mode in Realm of Legends - generate valid Commander decks#10224MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
Chaos mode generates random 60-card preconstructed decks, which is incompatible with Realm of Legends' 98-card minimum deck size requirement. Add an allowChaos config flag (default true) so individual adventures can opt out. Set it to false for Realm of Legends. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Looks good to me |
Agetian
previously approved these changes
Mar 31, 2026
Contributor
|
Would a valid alternative be to just tweak Chaos to generate a valid 100 card random commander deck? I believe we have code for generating those somewhere. Could use the config to specify a deck format for the chaos deck instead of making it a toggle. |
Contributor
|
That would indeed be a better (and preferred) implementation 👍 |
Replace allowChaos toggle with chaosDeckFormat config field. When set to "Commander", player and enemy decks use DeckgenUtil.generateCommanderDeck() to produce valid 100-card singleton decks, fixing ROL's 98-card minimum incompatibility. Adventures without the field keep default precon behavior. Chaos is also treated as commander-like for the deck editor when configured. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MostCromulent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10214
Addresses @VigilantSera request in #10214 — Chaos mode generates random 60-card preconstructed decks, incompatible with Realm of Legends' 98-card minimum deck size.
allowChaosconfig flag toConfigData(defaulttrue), consistent with the existingenableGeneticAIflag patternNewGameScenebehind this flag, matching how Precon/CommanderPrecon modes are conditionally addedallowChaos: falsein Realm of Legends'config.jsonNotes
true, so all other adventures are unaffected. Existing Realm of Legends saves are also unaffected — the flag only controls the new game screen mode picker, not gameplay or save loading.allowChaosfollows the same pattern asenableGeneticAI— a public boolean onConfigDatawith a default value, read directly inNewGameScene.🤖 Generated with Claude Code